Restore colors for word limit warning message in tinymce widget#4641
Merged
Conversation
The colors went missing with the daisyUI refactor 9cfc791
Member
|
Looks good. Thanks for finding and fixing all these bugs that creeped in! The daisyUI refactor was pushed through faster than normal since OTF was forces to cut back on development. |
Contributor
Author
I should say that my work was made possible thanks to a contract between my employer (Torchbox) and our client (DigitalHub.sh). A great example of companies contributing back to open source, I'd love to see more of that 💚 |
wes-otf
added
Status: Needs dev testing 🧑💻
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs dev testing 🧑💻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The colors went missing with the daisyUI refactor 9cfc791
The use of
!importantis not great, but it's already widespread inside this file (because the tinymce stylesheet is loaded after Hypha's and therefore takes precedence).Screenshots
Before
After